Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bug 21993 config:set not storing scoped values #22012

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

ochnygosch
Copy link
Contributor

Description (*)

Supply scope type and scope code to configFactory as data array, so that these values are forwarded to the Config instance.

Fixed Issues (if relevant)

  1. config:set not storing scoped values #21993: config:set not storing scoped values

Manual testing scenarios (*)

  1. see config:set not storing scoped values #21993: config:set not storing scoped values

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ochnygosch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 28, 2019

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Mar 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4602 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@ochnygosch thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii
Copy link

soleksii commented Apr 2, 2019

✔️ QA Passed

Result:

after

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2019

Hi @ochnygosch, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants