Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Bug fix for #21753 (2.2-develop) #22072

Merged
merged 4 commits into from
Apr 20, 2019

Conversation

crankycyclops
Copy link
Contributor

@crankycyclops crankycyclops commented Mar 31, 2019

Description (*)

Fixes the issue raised in #21753 by setting the initial downloadable item status to Available if \Magento\Downloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS is set to 'Pending.'

Fixed Issues (if relevant)

  1. Order Item Status to Enable Downloads is set to "Pending," but no download links are presented in "My Downloads" when logged in (fix provided) #21753

Manual testing scenarios (*)

  1. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Pending"
  2. Create a downloadable product in the admin
  3. Create a user account on the frontend and login
  4. Purchase a downloadable product. The product should be placed in the "available" state after successful completion of payment.
  5. Login to the admin and set Stores -> Configuration -> Catalog -> Downloadable Product Options -> Order Item Status to Enable Downloads to "Invoiced"
  6. Purchase the product again and note the second ordered item is in the "pending" status.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
    Backport for: Bug fix for #21753 (2.3-develop) #22073

…nloadable\Model\Link\Purchased\Item::XML_PATH_ORDER_ITEM_STATUS is set to 'Pending' (magento#21753)
@m2-assistant
Copy link

m2-assistant bot commented Mar 31, 2019

Hi @crankycyclops. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Mar 31, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 31, 2019

I'm putting this PR on hold until another version for 2.3 is merged

@crankycyclops
Copy link
Contributor Author

@rogyar, just letting you know when you're ready to merge that I've made the same changes to this branch that were requested in the PR for 2.3.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4777 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @crankycyclops, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants