Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fotorama - disabling swipe on the item with class "disableSwipe" #22089

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Fotorama - disabling swipe on the item with class "disableSwipe" #22089

merged 2 commits into from
Apr 23, 2019

Conversation

iGerchak
Copy link
Contributor

@iGerchak iGerchak commented Apr 1, 2019 •
edited by ihor-sviziev
Loading

Description

This fix adds the ability to disable swipe on the item.
For example canvas where you can draw something. Currently, we can't interactive with it because when we try to rotate an object, fotorama will slide to the next image.
This fix will check the active element and if it has "disableSwipe" class, it disables swipe and we'll interact with this element.

@iGerchak iGerchak requested a review from ihor-sviziev April 1, 2019 14:48
@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2019

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned ihor-sviziev Apr 2, 2019
ihor-sviziev
ihor-sviziev requested changes Apr 2, 2019
View reviewed changes
lib/web/fotorama/fotorama.js Outdated
@@ -1441,6 +1443,13 @@ fotoramaVersion = '4.6.4';
return;
}

$target = $(e.target);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like $target was never declared. Also if it used only once - it’s better to inline it’s value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$target was declared in the parent function.
Fixed.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-4643 has been created to process this Pull Request

@VasylShvorak VasylShvorak self-assigned this Apr 18, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2019

Hi @iGerchak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 87ec905 into magento:2.3-develop Apr 23, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 23, 2019
@sivaschenko
ENGCOM-4643: Fotorama - disabling swipe on the item with class "disab…
d130243 
…leSwipe" #22089
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@p-bystritsky p-bystritsky

@VasylShvorak VasylShvorak

Labels
Area: Lib/Frontend Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@iGerchak @magento-engcom-team @VasylShvorak @ihor-sviziev @p-bystritsky