Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiexed 22152 - Click on search icon it does not working on admin grid sticky header #22154

Conversation

niravkrish
Copy link
Contributor

Description (*)

Click on search icon it does not working on admin grid sticky header

Fixed Issues (if relevant)

  1. Click on search icon it does not working #22152: Click on search icon it does not working.

Manual testing scenarios (*)

  1. Manual Testing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2019

Hi @niravkrish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

@ghost ghost assigned orlangur Apr 4, 2019
@niravkrish
Copy link
Contributor Author

LGTM.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history

Hello @orlangur,

Can you please help me to remove unnecessary commits from this branch or PR?

Thanks
Nirav Patel

@niravkrish niravkrish requested a review from orlangur April 11, 2019 08:54
@niravkrish niravkrish force-pushed the fiexed-22152-search-icon-click-issue branch from 30d99ec to 6becfb9 Compare April 15, 2019 08:43
@niravkrish niravkrish force-pushed the fiexed-22152-search-icon-click-issue branch from 6becfb9 to 6cbf55d Compare April 15, 2019 08:51
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4761 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @niravkrish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants