Fixed category names in product edit for multi language stores. #22156

ekalinak · 2019-04-04T08:56:10Z

This pull request fixes problem reported in #22155

Description

In Multi store configuration, category names for different scopes are cached incorrectly on product edit form

Fixed Issues

Category scope Name cached incorrectly on product edit #22155: Category scope Name cached incorrectly on product edit

Manual testing scenarios (*)

Open "product edit" form
Change "Store View"

Category attribute displays correct category names for particular Store View

m2-assistant · 2019-04-04T08:56:12Z

Hi @ekalinak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

magento-cicd2 · 2019-04-04T08:56:16Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ekalinak
❌ Erik Kalinak

Erik Kalinak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Categories.php

orlangur

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

ekalinak · 2019-04-22T20:34:03Z

Everything done but tests weren't successful. I can't see what can be possibly wrong. @orlangur : Can you ?

orlangur · 2019-04-24T14:46:53Z

@ekalinak, error is pretty straightforward

There was 1 failure:
1) Magento\Catalog\Test\Unit\Ui\DataProvider\Product\Form\Modifier\CategoriesTest::testModifyMetaWithCaching
Expectation failed for method name is equal to 'load' when invoked 1 time(s)
Parameter 0 for invocation Magento\Framework\App\CacheInterface::load('CATALOG_PRODUCT_CATEGORY_TREE__') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'CATALOG_PRODUCT_CATEGORY_TREE_'
+'CATALOG_PRODUCT_CATEGORY_TREE__'
/home/travis/build/magento/magento2/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Categories.php:316
/home/travis/build/magento/magento2/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Categories.php:248
/home/travis/build/magento/magento2/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Categories.php:127
/home/travis/build/magento/magento2/app/code/Magento/Catalog/Test/Unit/Ui/DataProvider/Product/Form/Modifier/CategoriesTest.php:189

ekalinak · 2019-04-24T18:17:57Z

As I can see, it has no sense to continue here

Original code ( before suggestion ) would pass the tests
Meanwhile was added and merged commit 8d11456 which is fixing this bug

btw, logic of the code is not better from provided in this pull request, just author removed unit test from source code, so he can pass tests ( ??? )

@orlangur : I think you can close this pull request. ( It looks like whole time spend on creating issue and pull request worth for nothing .. :/ )

orlangur

@ekalinak your fix is much simpler than the one currently merged.

Please resolve conflicts and replace those changes with your ones, also, restoring a corresponding unit test.

Your PR now becomes not a bugfix but refactoring but it's still pretty cool.

…category tree caching and replaced with simpler one.

ekalinak · 2019-04-29T11:53:08Z

@orlangur : Everything seems to be OK, right ?

orlangur · 2019-06-14T12:58:06Z

@engcom-dev-Foxtrot go over https://github.com/magento/magento2/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee maybe? ;)

@ekalinak will check shortly.

engcom-Foxtrot · 2019-06-14T13:36:24Z

@magento run all tests

orlangur · 2019-09-26T21:48:38Z

@magento run all tests

kmvickers628 · 2019-10-21T18:03:33Z

@magento-admin @ekalinak hi there, i have been reviewing this thread here: #22155 and was curious if #22156 is the correct fix for issue 22155?

please confirm.

ekalinak · 2019-10-21T18:35:17Z

Hi @kmvickers628 . I've created issue #22155 and also fix for it in this pull request. I've also applied this fix on one of installations I'm working on, and it's working.

Can you please explain, where is the problem exactly ?

alexblueacorn · 2019-10-21T19:14:33Z

Why this issue linked to this PR ?

Is this a mistake ?

kmvickers628 · 2019-10-21T19:30:02Z

@ekalinak , alexblueacorn provided a question above.

ekalinak · 2019-10-21T20:07:26Z

@alexblueacorn : I don't know from where you have the screen, but from my point of view it is a mistake. This PR is fixing category names in product edit for multi language stores.

alexblueacorn · 2019-10-21T20:34:43Z

From this page.
https://devdocs.magento.com/guides/v2.3/release-notes/release-notes-2-3-3-commerce.html

Looks like they included wrong PR. So I'm trying find right one for reindexing issue.

kmvickers628 · 2019-10-23T13:09:01Z

@ekalinak are you able to help Alex find the correct PR? thanks!

ekalinak · 2019-10-24T20:14:22Z

@kmvickers628 : All I know that issue #22155 is fixed by this pull reqeust. I have no idea which PR is fixing indexing problem :/ How should I even find out ? By studying code from pull requests ?

mightyknite · 2019-12-23T12:51:29Z

@alexblueacorn That is typo on https://devdocs.magento.com/guides/v2.3/release-notes/release-notes-2-3-3-commerce.html
Correct PR is #22516

ihor-sviziev · 2020-03-03T15:49:06Z

Hi @orlangur @ekalinak,
Could you info what's the status of this PR and what's left?

Update: I already understood the status

ihor-sviziev

Hi @ekalinak,

Looks like method getCategoriesTree was split to few smaller methods in 2.4-develop branch, while your PR currently reverting it, that looks incorrect. Could you sign Adobe CLA and update your PR to not combining all changes back into single method?

ekalinak · 2020-03-03T20:30:04Z

@ihor-sviziev : Omg, this is already one year old PR. Originally I submitted code to 2.3-develop branch. I understand that there are changes in 2.4-develop, but at the moment I have no time to investigate changes and again change my code. I'm closing this PR. After almost a year, this probably won't help anybody .. 😕

m2-assistant · 2020-03-03T20:30:07Z

Hi @ekalinak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ihor-sviziev · 2020-03-03T20:39:28Z

@ekalinak
I’m so sorry that it took so long period to review and I’m fully understand your point. Now I’m trying to finalize all pull requests that weren’t processed due to different reasons.
Thank you for contribution and hope your next contribution will be processed much quicker

magento-engcom-team added Component: Catalog Release Line: 2.3 labels Apr 4, 2019

orlangur requested changes Apr 4, 2019

View reviewed changes

app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Categories.php Show resolved Hide resolved

ghost assigned orlangur Apr 4, 2019

ghost added the Progress: needs update label Apr 4, 2019

orlangur requested changes Apr 8, 2019

View reviewed changes

Fixed category names in product edit for multi language stores.

2778acb

ekalinak force-pushed the fix-multistore-cateogry-names branch from 98c6bc2 to 2778acb Compare April 8, 2019 19:14

orlangur requested changes Apr 24, 2019

View reviewed changes

ekalinak and others added 2 commits April 25, 2019 10:03

Merge branch '2.3-develop' into fix-multistore-cateogry-names

7b3f050

Re-added test for category tree, removed already merged solution for …

39d84be

…category tree caching and replaced with simpler one.

engcom-Foxtrot removed the Progress: needs update label Jun 14, 2019

engcom-Foxtrot requested a review from orlangur June 14, 2019 12:46

sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:21

sidolov added Release Line: 2.4 and removed Release Line: 2.3 labels Dec 5, 2019

ihor-sviziev self-assigned this Mar 3, 2020

Merge branch '2.4-develop' into fix-multistore-cateogry-names

59efbaf

ghost added the Progress: pending review label Mar 3, 2020

ihor-sviziev requested changes Mar 3, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Mar 3, 2020

ekalinak closed this Mar 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed category names in product edit for multi language stores. #22156

Fixed category names in product edit for multi language stores. #22156

ekalinak commented Apr 4, 2019

m2-assistant bot commented Apr 4, 2019

magento-cicd2 commented Apr 4, 2019 •

edited

Loading

orlangur left a comment

ekalinak commented Apr 22, 2019

orlangur commented Apr 24, 2019

ekalinak commented Apr 24, 2019

orlangur left a comment

ekalinak commented Apr 29, 2019

orlangur commented Jun 14, 2019

engcom-Foxtrot commented Jun 14, 2019

orlangur commented Sep 26, 2019

kmvickers628 commented Oct 21, 2019 •

edited

Loading

ekalinak commented Oct 21, 2019

alexblueacorn commented Oct 21, 2019

kmvickers628 commented Oct 21, 2019

ekalinak commented Oct 21, 2019

alexblueacorn commented Oct 21, 2019

kmvickers628 commented Oct 23, 2019

ekalinak commented Oct 24, 2019

mightyknite commented Dec 23, 2019

ihor-sviziev commented Mar 3, 2020 •

edited

Loading

ihor-sviziev left a comment •

edited

Loading

ekalinak commented Mar 3, 2020

m2-assistant bot commented Mar 3, 2020

ihor-sviziev commented Mar 3, 2020

Fixed category names in product edit for multi language stores. #22156

Fixed category names in product edit for multi language stores. #22156

Conversation

ekalinak commented Apr 4, 2019

Description

Fixed Issues

Manual testing scenarios (*)

m2-assistant bot commented Apr 4, 2019

magento-cicd2 commented Apr 4, 2019 • edited Loading

orlangur left a comment

Choose a reason for hiding this comment

ekalinak commented Apr 22, 2019

orlangur commented Apr 24, 2019

ekalinak commented Apr 24, 2019

orlangur left a comment

Choose a reason for hiding this comment

ekalinak commented Apr 29, 2019

orlangur commented Jun 14, 2019

engcom-Foxtrot commented Jun 14, 2019

orlangur commented Sep 26, 2019

kmvickers628 commented Oct 21, 2019 • edited Loading

ekalinak commented Oct 21, 2019

alexblueacorn commented Oct 21, 2019

kmvickers628 commented Oct 21, 2019

ekalinak commented Oct 21, 2019

alexblueacorn commented Oct 21, 2019

kmvickers628 commented Oct 23, 2019

ekalinak commented Oct 24, 2019

mightyknite commented Dec 23, 2019

ihor-sviziev commented Mar 3, 2020 • edited Loading

ihor-sviziev left a comment • edited Loading

Choose a reason for hiding this comment

ekalinak commented Mar 3, 2020

m2-assistant bot commented Mar 3, 2020

ihor-sviziev commented Mar 3, 2020

magento-cicd2 commented Apr 4, 2019 •

edited

Loading

kmvickers628 commented Oct 21, 2019 •

edited

Loading

ihor-sviziev commented Mar 3, 2020 •

edited

Loading

ihor-sviziev left a comment •

edited

Loading