fatalErrorHandler returns 500 only on fatal errors #22200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatalogErrorHandler should return 500 only on fatal errors - otherwise, even a simple deprecation warning on the page triggers internal server error, which is invalid.
|
Hi @wexo-team. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
|
rogyar
approved these changes
Apr 8, 2019
ghost
added
Progress: ready for testing
Progress: extended testing
and removed
Progress: ready for testing
labels
|
@wexo-team thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
|
Hi @wexo-team, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fatalogErrorHandler should return 500 only on fatal errors - otherwise, even a simple deprecation warning on the page triggers internal server error, which is invalid.
Fixes issue #22199