-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] [Widget] Fixing the multidimensional array as value for the widget's parameter #22214
[Backport] [Widget] Fixing the multidimensional array as value for the widget's parameter #22214
Conversation
Hi @ilnytskyi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phpcs:ignore
does not have effect in 2.2-develop
AFAIK but let's leave it.
Hi @orlangur, thank you for the review. |
Hi @ilnytskyi, thank you for your contribution! |
… value for the widget's parameter #22214
Hi @ilnytskyi , could you give us an practical example of how in this case the Element.php of this parameter should be? , because im having difficulties creating one like in the image you loaded. |
@klaudiomaraj unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request |
Original Pull Request
#21008
Description (*)
This PR gives the possibility to use a multi row field as a parameter for a widget.
After saving the widget, or opening, you'll have 2 exceptions thrown:
Warning: html_entity_decode() expects parameter 1 to be string, array given in /home/dev/sites/mage23/app/code/Magento/Widget/Block/Adminhtml/Widget/Options.php on line 170
Warning: htmlspecialchars() expects parameter 1 to be string, array given in /home/dev/sites/mage23/lib/internal/Magento/Framework/Data/Form/Element/AbstractElement.php on line 290
As a result, you should are able to save and open the widget:
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)