Prevented /Magento/Sales/Model/Service/InvoiceService.php incorrectly…

[ryanpalmerweb]

Description (*)

When calling Magento\Sales\Model\Service\InvoiceService::prepareInvoice without a quantity specified, the function no longer (incorrectly) discards items when bundled items have been processed

Fixed Issues (if relevant)

1. Programatically created invoices miss items when both simple products and bundled products are mixed in an order #22246: Programatically created invoices miss items when both simple products and bundled products are mixed in an order

Manual testing scenarios (*)

1. Create an order containing both a bundled product and a simple product
2. Check out with a payment method which does not automatically create an invoice
3. Programatically get an instance of the order, and then run the following code

$invoice = $order->prepareInvoice();
$invoice->getOrder()->setIsInProcess(true);
$invoice->register()->pay();
$invoice->save();

4. Simple products without a parent will no longer be missed from the invoice

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[m2-assistant]

Hi @ryanpalmerweb. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-cicd2]

All committers have signed the CLA.

[orlangur]

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

[ryanpalmerweb]

@orlangur Was that addressed to me? I made the change requested but the commits were not squashed.

[orlangur]

@ryanpalmerweb yep, please squash.

[ryanpalmerweb]

@ryanpalmerweb yep, please squash.

should be squashed now?

[orlangur]

@ryanpalmerweb 👌

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-4739 has been created to process this Pull Request

[magento-engcom-team]

@ryanpalmerweb thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[VasylShvorak]

✔️ QA passed

[m2-assistant]

Hi @ryanpalmerweb, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.