Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #22223 Missing/Wrong data display on downloadable report table … #22291

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Fixed #22223 Missing/Wrong data display on downloadable report table … #22291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b881a5d
Fixed #22223 Missing/Wrong data display on downloadable report table …
Apr 11, 2019
bf8e919
Code style fix
rogyar Apr 13, 2019
0453184
magento/magento2#22291: Static test fix.
p-bystritsky Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions app/code/Magento/Reports/Model/ResourceModel/Product/Downloads/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,16 @@
* See COPYING.txt for license details.
*/

namespace Magento\Reports\Model\ResourceModel\Product\Downloads;

/**
* Product Downloads Report collection
*
* @author Magento Core Team <core@magentocommerce.com>
*/
namespace Magento\Reports\Model\ResourceModel\Product\Downloads;

/**
*
* @api
* @since 100.0.2
* @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
*/
class Collection extends \Magento\Catalog\Model\ResourceModel\Product\Collection
{
Expand Down Expand Up @@ -97,4 +97,14 @@ public function addFieldToFilter($field, $condition = null)
}
return $this;
}

/**
* @inheritDoc
*/
public function getSelectCountSql()
{
$countSelect = parent::getSelectCountSql();
$countSelect->reset(\Zend\Db\Sql\Select::GROUP);
return $countSelect;
}
}