Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22299: Cms block cache key does not contain the store id #22302

Merged
merged 2 commits into from
Apr 28, 2019

Conversation

tzyganu
Copy link
Contributor

@tzyganu tzyganu commented Apr 12, 2019

Description (*)

This PR adds the current store id to the cms blocks cache key to avoid rendering the wrong cms block on different store views

Fixed Issues (if relevant)

  1. Cms block cache key does not contain the store id #22299: Cms block cache key does not contain the store id

Manual testing scenarios (*)

Steps to reproduce are listed in the issue #22299

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @tzyganu. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 12, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4745 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@tzyganu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@tzyganu
Copy link
Contributor Author

tzyganu commented Apr 12, 2019

@orlangur @magento-engcom-team how to I start the travis ci build? It did not start at all

@arnoudhgz
Copy link
Contributor

@tzyganu FYI the tests start automatically ;)

@soleksii soleksii closed this Apr 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2019

Hi @tzyganu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2019

Hi @tzyganu, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants