-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout Totals Sort Order fields can't be empty and should be a number. #22413
Conversation
Same fix than PR 22411 on 2.3.
Hi @barbanet. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @miguelbalparda, thank you for the review. |
✔️ QA passed |
Hi @sidolov, thank you for the review. |
✔️ QA passed |
Hi @barbanet, thank you for your contribution! |
Same fix than #22411 on 2.3.
If, for some reason, a backend user deletes the content of one or all Configuration -> Sales -> Sales -> Checkout Totals Sort Order fields, the checkout won't work and you won't see an error and no exceptions seems to be logged.
Description (*)
Now, field Subtotal, Discount, Shipping, Tax, Fixed Product Tax and Grand Total; inside Configuration -> Sales -> Sales -> Checkout Totals Sort Order, are required and can't be empty anymore.
Manual testing scenarios (*)
Exactly the same steps than #22411.
I'm just applying the fix for 2.2.
Contribution checklist (*)