Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /V1/products/:sku/media/:entryId does not change the file #22424

Merged
merged 3 commits into from
Apr 27, 2019
Merged

PUT /V1/products/:sku/media/:entryId does not change the file #22424

merged 3 commits into from
Apr 27, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Apr 19, 2019

Description (*)

When update product image via Api image not replaced because $entry->getFile() return null.

Fixed Issues (if relevant)

  1. PUT /V1/products/:sku/media/:entryId does not change the file #22402: Issue title

Manual testing scenarios (*)

  1. Send the following PUT request to "/V1/products/24-WG080/media/52"
    base64_encoded_data is empty as this would bloat the issue-text

{"entry":{"media_type":"image","label":"Label for my Image":1,"disabled":false,"types":["image","small_image","thumbnail"],"content":{"base64_encoded_data":"...","type":"image/jpeg","name":"luma-yoga-kit-2"},"id":52}}

  1. Everything provided by the request is updated for the media entity
  2. The actual file-content is replaced with what is provided in the base64_encoded_data
  3. The endpoint returns true

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2019

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned rogyar Apr 19, 2019
@soleksii soleksii self-assigned this Apr 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4786 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

@philippsander
Copy link
Member

PUT is idempotent, so I do not 100% agree with this fix as it creates a new entity with a new ID which prevents the same requests being called again.

@Nazar65
Copy link
Member Author

Nazar65 commented Apr 24, 2019

@philippsander this fix does not create new entity, just updates entity id, as this worked before, i'm just added case with base64 encoded data

@philippsander
Copy link
Member

ok. but still not idempotent ;-)

@m2-assistant
Copy link

m2-assistant bot commented Apr 27, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants