-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bakport] Adding product from wishlist not adding to cart showing warning message. #22536
[Bakport] Adding product from wishlist not adding to cart showing warning message. #22536
Conversation
Hi @niravkrish. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @niravkrish,
the current solution does not seem to be working.
The \Magento\Wishlist\Block\Customer\Wishlist\Item\Column\Cart
cannot be instantiated due to the redundant constructor params, and namely \Magento\Catalog\Model\Product\Image\UrlBuilder
which is not available in Magento 2.2.x version.
Please make sure the changes are working and compatible with Magento 2.2.x before creating a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niravkrish, could you please squash all commits into a single commit after applying the changes in order to clean up history?
Thank you!
app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Cart.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Wishlist/Block/Customer/Wishlist/Item/Column/Cart.php
Outdated
Show resolved
Hide resolved
a77ec3b
to
4b3df81
Compare
9446860
to
c62ab93
Compare
Hi @dmytro-ch, thank you for the review. |
✔️ QA passed |
Hi @niravkrish, thank you for your contribution! |
…t showing warning message. #22536
Hi @niravkrish . Thank you for your contribution. Unfortunately, we needed to revert this fix for the 2.2.9 release, as it includes BIC into a patch release. |
- reverting #22536, because of Backward Incompatible changes in the patch release
Original Pull Request
#19653
Description (*)
Adding product from wishlist not adding to cart showing warning message.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)