Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] [Fixed] Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL #22543

Merged

Conversation

saphaljha
Copy link
Contributor

Original Pull Request

#22405

Description (*)

Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL

Fixed Issues (if relevant)

  1. Checkout: it is possible to leave blank Shipping Details section and get to Payment Details section by URL #21596: Checkout Section: Shipping step is getting skipped when customer hitting direct payment step URL

Manual testing scenarios (*)

  1. Product Add To Cart and go to checkout page
  2. hit payment url without adding shipping address

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 29, 2019

Hi @saphaljha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-4856 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented May 3, 2019

Hi @saphaljha, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request May 3, 2019
…tting skipped when customer hitting direct payment step URL #22543
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.9 milestone May 3, 2019
@saphaljha saphaljha deleted the 2.2-develop-PR-port-22405 branch September 24, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants