Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change exportButton option cvs #22671

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Change exportButton option cvs #22671

merged 1 commit into from
Jun 26, 2019

Conversation

ajeetsinghcedcoss
Copy link
Member

Change exportButton option cvs

Description (*)

Grid exportButton having two option cvs and xml, If some one want to add option with csv name, value and Lable then by default cvs option add,

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. Change exportButton option cvs

Manual testing scenarios (*)

  1. exportButton option having name cvs and value is csv, lable CSV
  2. If we add csv option then exportButton having 3 option (1. name: cvs Lable:CSV , 2. name: csv Lable:CSV, 3. name: xml Lable: Excel XML

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Change exportButton option cvs 
<option name="csv" xsi:type="array">
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @ajeetsinghcedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@federivo
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @federivo. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @federivo, here is your new Magento instance.
Admin access: https://pr-22671.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@federivo federivo self-requested a review June 25, 2019 13:33
@federivo
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @federivo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @federivo, here is your Magento instance.
Admin access: https://i-22671-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @federivo, thank you for the review.
ENGCOM-5351 has been created to process this Pull Request
✳️ @federivo, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@federivo
Copy link
Member

@ajeetsinghcedcoss thanks for your contribution.

@federivo federivo added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 25, 2019
@engcom-Delta engcom-Delta self-assigned this Jun 26, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @ajeetsinghcedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants