Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #20038 loading icon disappearing before background process completes for Braintree payment in Admin #22675

Merged
merged 3 commits into from Jun 21, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 4, 2019

Description (*)

Fixed Issues (if relevant)

  1. loading icon disappearing before background process completes for braintree payment (Admin order) #20038: loading icon disappearing before background process completes for braintree payment (Admin order)

Manual testing scenarios (*)

  1. Login to the Admin
  2. Create a order for a customer
  3. Use Credit Card(BrainTree) payment method
  4. Click 'Submit Order' button
  5. Full page loader should be visible until user is redirected to succes page or error occurs.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @kunal-rtpl. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 4, 2019

CLA assistant check
All committers have signed the CLA.

@ronak2ram ronak2ram self-assigned this May 4, 2019
@ronak2ram
Copy link
Member

Hi @kunal-rtpl, please, sign CLA, otherwise, we can't process your pull request.

@ghost
Copy link
Author

ghost commented May 5, 2019

Hi @kunal-rtpl, please, sign CLA, otherwise, we can't process your pull request.

Hi ronak2ram, signed

@ghost ghost assigned sidolov Jun 19, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5324 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @kunal-rtpl, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 21, 2019
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2019
… process completes for Braintree payment in Admin #22675
@geet07 geet07 added Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner labels Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Braintree Partner: Ranosys Pull Request is created by Ranosys Technologies partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants