Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify a field to be checked in the response #22844

Merged
merged 1 commit into from
May 14, 2019
Merged

Allow to specify a field to be checked in the response #22844

merged 1 commit into from
May 14, 2019

Conversation

diazwatson
Copy link
Contributor

Description (*)

Trying to make this component more extensible by adding the possibility to pass a field to check.
If no field is passed default is used.

Fixed Issues (if relevant)

  1. [Story #6] User configures Adobe Stock integration adobe-stock-integration#29

@m2-assistant
Copy link

m2-assistant bot commented May 12, 2019

Hi @diazwatson. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov May 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5104 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit b525fa4 into magento:2.3-develop May 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 14, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants