Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get review entity id by code instead hard-coded. #23353

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Get review entity id by code instead hard-coded. #23353

merged 2 commits into from
Jun 27, 2019

Conversation

daniloargentiero
Copy link

Description (*)

Get review entity id by code instead hard-coded on save review from adminhtml.

Fixed Issues (if relevant)

Haven't found related issues.

Manual testing scenarios (*)

  1. Create a product review from adminhtml
  2. If your entity id in review_entity has changed, save will fail

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @DaniloEmpire. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 21, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5337 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@orlangur orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 21, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jun 24, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit a3016bc into magento:2.3-develop Jun 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2019

Hi @DaniloEmpire, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 27, 2019
@daniloargentiero daniloargentiero deleted the fix/save-review-from-adminhtml branch July 2, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Review Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants