Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rogue closing tag from store-switcher template #23403

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Remove rogue closing tag from store-switcher template #23403

merged 1 commit into from
Jun 27, 2019

Conversation

sta1r
Copy link
Contributor

@sta1r sta1r commented Jun 25, 2019

Description (*)

A PHP closing tag has been left behind in the HTML after this commit, and is visible when switching store.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. 2.3 develop
  2. Create multiple websites
  3. Go to Stores > Configuration
  4. Switch to a different website
  5. You should not see this!

Screenshot 2019-06-25 17 11 38

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 25, 2019

Hi @sta1r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost assigned sidolov Jun 25, 2019
@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup labels Jun 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5356 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2019

Hi @sta1r, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants