Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Added function to check against running/pending/successful cron tasks #23439

Merged

Conversation

ihor-sviziev
Copy link
Contributor

Original Pull Request

#23312

This PR adds function to filter all correctly run, running or pending cron tasks.

Description (*)

If a cron has just been run, cache is cleared and the cron processed again, then scheduled tasks reschedule for the same time.

Fixed Issues (if relevant)

  1. Cron schedule is being duplicated #21380: Cron schedule is being duplicated

Manual testing scenarios (*)

When not updated, running bin/magento cron:run && bin/magento cache:flush repeatedly will cause tasks that have completed to be rescheduled - leading to many tasks repeating. This should no longer happen.

chickenland and others added 2 commits June 27, 2019 13:55
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2019

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-5365 has been created to process this Pull Request
✳️ @VladimirZaets, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jul 4, 2019

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jul 4, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jul 4, 2019
@VladimirZaets VladimirZaets added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Cron Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants