-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#: Incorrect annotation in the Magento/Framework/MessageQueue/etc/queue.xsd schema #24447
magento/magento2#: Incorrect annotation in the Magento/Framework/MessageQueue/etc/queue.xsd schema #24447
Conversation
Hi @atwixfirster. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
…ageQueue/etc/queue.xsd schema
60d3174
to
ba0fb9b
Compare
Since DB-based message queue still require this file (https://github.com/magento/magento2/blob/2.3/app/code/Magento/MysqlMq/Model/Driver/Exchange.php#L44) I believe it's a good catch. |
Hi @rogyar, thank you for the review. |
…ramework/MessageQueue/etc/queue.xsd schema #24447
Hi @atwixfirster, thank you for your contribution! |
Description (*)
Per my opinion
Magento/Framework/MessageQueue/etc/queue.xsd
schema contains incorrect annotations.When you configure Message Queue via
RabbitMQ
storage (amqp
connection type) then annotation is correct because developer specifies all details in the filesand Magento\Framework\Amqp\Exchange::enqueue reads a configuration data from the
communication.xml
file.However, when a developer wants to process Message Queue via
MySQL
storage (db
connection type) then it has to usequeue.xml
because Magento\MysqlMq\Model\Driver\Exchange::enqueue reads configuration data from that file.Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Thank you!