Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#: Incorrect annotation in the Magento/Framework/MessageQueue/etc/queue.xsd schema #24447

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Sep 4, 2019

Description (*)

Per my opinion Magento/Framework/MessageQueue/etc/queue.xsd schema contains incorrect annotations.

When you configure Message Queue via RabbitMQ storage (amqp connection type) then annotation is correct because developer specifies all details in the files

  • communication.xml
  • queue_consumer.xml
  • queue_publisher.xml
  • queue_topology.xml

and Magento\Framework\Amqp\Exchange::enqueue reads a configuration data from the communication.xml file.

However, when a developer wants to process Message Queue via MySQL storage (db connection type) then it has to use queue.xml because Magento\MysqlMq\Model\Driver\Exchange::enqueue reads configuration data from that file.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2019

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Sep 4, 2019
@rogyar rogyar self-assigned this Sep 4, 2019
@rogyar
Copy link
Contributor

rogyar commented Sep 4, 2019

Since DB-based message queue still require this file (https://github.com/magento/magento2/blob/2.3/app/code/Magento/MysqlMq/Model/Driver/Exchange.php#L44) I believe it's a good catch.
Also, a similar practice of using an explanation of deprecation in XSD schemas can be found here

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5765 has been created to process this Pull Request

@engcom-Foxtrot engcom-Foxtrot self-assigned this Sep 5, 2019
magento-engcom-team pushed a commit that referenced this pull request Sep 5, 2019
@magento-engcom-team magento-engcom-team merged commit ba0fb9b into magento:2.3-develop Sep 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 5, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: MessageQueue Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants