Optimize performance by using isset() instead of in_array()

[andrey-legayev]

Description (*)

I've run XDebug profiler to see why static content deploy takes so much time.
Many calls of in_array() grabbed my attention and I've fixed two such places:

1. lib/internal/Magento/Framework/Module/ModuleList/Loader.php
2. lib/internal/Magento/Framework/Setup/Lists.php

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

General regression testing.

Questions or comments

N/A

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @andrey-legayev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[andrey-legayev]

I need a help with following code issue:

FILE: ...html/lib/internal/Magento/Framework/Module/ModuleList/Loader.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 203 | WARNING | Direct throw of generic Exception is discouraged.
     |         | Use context specific instead.

@ihor-sviziev do you have an idea which exception should be thrown instead of \Exception ?

[ihor-sviziev]

Hi @andrey-legayev,
I think \Exception there could be replaced to \LogicException

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5923 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[andrey-legayev]

Updates:

• fixed merge conflict
• replaced one more in_array inside loop by isset()

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-5923 has been created to process this Pull Request

[engcom-Bravo]

✔️ QA passed

[m2-assistant]

Hi @andrey-legayev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.