Skip to content

Fixed bug when static content deploys including static data from disa… #24772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed bug when static content deploys including static data from disa… #24772

wants to merge 2 commits into from

Conversation

rganzhuyev
Copy link

…bled modules.

#24666

Description (*)

Fixed logic for css preprocessor to check if module is enabled before including its less / css resources to the generated static styles.

Fixed Issues (if relevant)

  1. Static content is deploying for disabled modules #24666

@rganzhuyev rganzhuyev requested a review from DrewML as a code owner September 27, 2019 15:04
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @rganzhuyev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sidolov
sidolov requested changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, cover changes with automated tests

lib/internal/Magento/Framework/Css/PreProcessor/Instruction/MagentoImport.php Outdated
*/
public function __construct(
DesignInterface $design,
CollectorInterface $fileSource,
ErrorHandlerInterface $errorHandler,
\Magento\Framework\View\Asset\Repository $assetRepo,
\Magento\Framework\View\Design\Theme\ListInterface $themeList
\Magento\Framework\View\Design\Theme\ListInterface $themeList,
ModuleManagerInterface $moduleManager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, inject new dependencies according to our Backward Compatible Development Guide

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@ghost ghost assigned sidolov Sep 27, 2019
ihor-sviziev
ihor-sviziev requested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rganzhuyev,
Could you review test failures and adjust code or tests itself (if they outdated)?

Also would be great to cover your changes with integration or unit test. Could you do that?

@ghost ghost assigned ihor-sviziev Oct 2, 2019
@rganzhuyev
Copy link
Author

rganzhuyev commented Oct 4, 2019 •
edited
Loading

Hi @rganzhuyev,
Could you review test failures and adjust code or tests itself (if they outdated)?

Also would be great to cover your changes with integration or unit test. Could you do that?

Yeah, could review and adjust this weekend.

@VladimirZaets
Copy link
Contributor

@rganzhuyev , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2019

Hi @rganzhuyev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets VladimirZaets self-assigned this Oct 18, 2019
@Echron Echron mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@sidolov sidolov sidolov requested changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@ihor-sviziev ihor-sviziev

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels
Component: Css Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rganzhuyev @magento-cicd2 @VladimirZaets @ihor-sviziev @sidolov @magento-engcom-team