Use in_array instead of array_search + comparison
#24886
Conversation
This has some benefits, such as reducing the tasks, as well as improving the readability of the code.
carusogabriel
requested review from
akaplya,
buskamuza,
YevSent,
melnikovi,
paliarush and
tariqjawed83
as code owners
|
Hi @carusogabriel. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
|
Hi @carusogabriel . Thanks for your PR. Can you check the tests details and solve the errors. |
| @@ -135,6 +135,6 @@ private function validateCipherMethod($cipherMethod) | |||
| ); | |||
| $cipherMethod = strtolower($cipherMethod); | |||
|
|
|||
| return (false !== array_search($cipherMethod, $methods)); | |||
| return in_array($cipherMethod, $methods); | |||
There was a problem hiding this comment.
I would like to replace both array_search & in_array to array_flip + isset.
Reason: magento/magento-coding-standard#143
@carusogabriel @osrecio what do you think about it?
There was a problem hiding this comment.
Followin the thread I think is better to usee array_flip + isset.
If @carusogabriel agree with us, he can perform the changes and for me will be ready to be merged :)
There was a problem hiding this comment.
@osrecio I'll do it :)
|
Hi @carusogabriel, thank you for your contribution! |
Description (*)
This has some benefits, such as reducing the tasks, as well as improving the readability of the code.
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Not necessary
Questions or comments
Contribution checklist (*)