Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No translation from "Orders and Returns" footer links #2492

Merged
merged 1 commit into from
Aug 12, 2016
Merged

No translation from "Orders and Returns" footer links #2492

merged 1 commit into from
Aug 12, 2016

Conversation

Amadeco
Copy link

@Amadeco Amadeco commented Nov 23, 2015

Orders and Returns footer links, miss param translate="true"

/app/code/Magento/Sales/view/frontend/layout/default.xml
Line 19

<argument name="label" xsi:type="string">Orders and Returns</argument>

to

<argument name="label" xsi:type="string" translate="true">Orders and Returns</argument>

Cheers

No translation from "Orders and Returns" footer links
211e9a5 
Orders and Returns footer links, miss param translate="true"

/app/code/Magento/Sales/view/frontend/layout/default.xml
Line 19

```xml
<argument name="label" xsi:type="string">Orders and Returns</argument>
```

to

```xml
<argument name="label" xsi:type="string" translate="true">Orders and Returns</argument>
```

Cheers
@Amadeco Amadeco mentioned this pull request Nov 23, 2015
Closed
@Vinai Vinai added the CS label Nov 25, 2015
@Vinai
Copy link
Contributor

Vinai commented Nov 25, 2015

Thank you for your contribution! We will need to wait until the travis build authentication is fixed for the tests to pass, and then we can continue processing your PR.

@KrystynaKabannyk
Copy link

Hello @mageho, can you please update the code and cover it by Travis tests?

@NadiyaS
Copy link
Contributor

NadiyaS commented May 10, 2016 •
edited
Loading

Hi @mageho ,
thank you for contribution and we are sorry for delay.
Internal ticket MAGETWO-52646 was created to process your PR.
Please upgrade your code with develop branch and rerun builds. And be sure that travis builds are not failed

@NadiyaS NadiyaS added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: needs update labels May 10, 2016
@vasiliyseleznev vasiliyseleznev removed the CS label Aug 3, 2016
@vkorotun vkorotun added Component: Sales bugfix and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 3, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@mmansoor-magento mmansoor-magento merged commit 211e9a5 into magento:develop Aug 12, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-52646: [GITHUB] No translation from "Orders and Returns" foot…
958c212 
…er links #2492
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NadiyaS NadiyaS

Labels
bugfix Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Amadeco @Vinai @KrystynaKabannyk @NadiyaS @vkublytskyi @vasiliyseleznev @mmansoor-magento @vkorotun @sshrewz