Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-16315 - add prevent for ignoring product website assignments in… #24925

Closed

Conversation

idziakjakub
Copy link
Contributor

… "Update on save" product flat indexer mode

Description (*)

This fix loads only store views that are connected to product to avoid save reindexed row to all product flat tables in the database. The problem occurred only in "Update on save" mode for "Product Flat Data" indexer.

Fixed Issues (if relevant)

  1. Product save with onthefly index ignores website assignments #16315: Product save with onthefly index ignores website assignments

Manual testing scenarios (*)

  1. Create 2 websites and 2 store views
  2. Assign first store view to first website and second store view to second website
  3. Add product and assign only to first website
  4. Save product
  5. Check if product is assigned to second store view

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@idziakjakub idziakjakub requested a review from akaplya as a code owner October 8, 2019 14:24
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @idziakjakub. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @idziakjakub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@idziakjakub idziakjakub reopened this Oct 8, 2019
@idziakjakub idziakjakub closed this Oct 8, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 8, 2019

Hi @idziakjakub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@idziakjakub idziakjakub reopened this Oct 8, 2019
@idziakjakub idziakjakub force-pushed the fix-product-flat-on-save branch from fee8eb9 to 714e2db Compare October 9, 2019 07:26
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:19
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idziakjakub could you please sign CLA so we will be able to proceed with this PR?

@ghost ghost assigned lenaorobei Mar 5, 2020
@lenaorobei
Copy link
Contributor

Closing this PR due to inactivity. Please feel free to reopen if you are going to continue working on it.
Thank you.

@lenaorobei lenaorobei closed this Mar 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 19, 2020

Hi @idziakjakub, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants