Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue related to select all option in admin grid in review sec… #25234

Closed
wants to merge 5 commits into from
Closed

Fixing issue related to select all option in admin grid in review sec… #25234

wants to merge 5 commits into from

Conversation

webkul-ratnesh
Copy link
Contributor

@webkul-ratnesh webkul-ratnesh commented Oct 23, 2019 •
edited
Loading

Description (*)

Fixing issue related to select all option in admin grid in review section even by this fix all the grid's select all issue will be fixed #12594

Fixed Issues (if relevant)

  1. Couldn't select all items on Review grid #12594: Couldn't select all items on Review grid

Manual testing scenarios (*)

  1. Goto Marketing -> User Content -> All Reviews
  2. Try selecting all items in grid for mass updating status.
  3. It should select all items exist in grid not only visible items

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@webkul-ratnesh
Fixing issue related to select all option in admin grid in review sec…
d7fd4ea 
…tion even by this fix all the grid's select all issue will be fixed magento#12594
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @webkul-ratnesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@webkul-ratnesh
Update Extended.php
4c99998 
Updating after fixing unit test issue.
@webkul-ratnesh
Update Extended.php
1c8d2ce 
Updating after adding array check.
@webkul-ratnesh
Copy link
Contributor Author

@paliarush Hello,
Can you please explain what exactly issue this PR has, as there is nothing details mentioned in allure.

@webkul-ratnesh
Update Extended.php
47d82c9 
Reverting array check
@webkul-ratnesh
Update Extended.php
7eeb6f9 
Updating invalid argument passed  issue.
@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 22, 2020
lenaorobei
lenaorobei requested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to properly fix this issue please consider rewriting this grid with UI components.
See issue thread for more details.

@ghost ghost assigned lenaorobei Aug 17, 2020
@VladimirZaets VladimirZaets self-assigned this Aug 26, 2020
@engcom-Charlie engcom-Charlie self-assigned this Aug 27, 2020
@engcom-Charlie
Copy link
Contributor

Hi @webkul-ratnesh could you please take a look at the #25234 (review)?
Thank you.

@sidolov
Copy link
Contributor

sidolov commented Sep 4, 2020

@webkul-ratnesh I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Sep 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 4, 2020

Hi @webkul-ratnesh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei requested changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@VladimirZaets VladimirZaets

@lenaorobei lenaorobei

@engcom-Charlie engcom-Charlie

Labels
Component: Backend Priority: P3 May be fixed according to the position in the backlog. Progress: needs update Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Squashtoberfest 2019
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Couldn't select all items on Review grid
6 participants
@webkul-ratnesh @engcom-Charlie @sidolov @lenaorobei @VladimirZaets @magento-engcom-team