Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/25312 Add Colombian regions #25313

Merged
merged 1 commit into from
Nov 26, 2019
Merged

feature/25312 Add Colombian regions #25313

merged 1 commit into from
Nov 26, 2019

Conversation

magudelo62
Copy link
Contributor

Description (*)

Add Colombian Regions

Fixed Issues (if relevant)

  1. Add Colombian regions #25312: Add Colombian regions

Manual testing scenarios (*)

Add product to cart
Go to checkout
Select Colombia as shipping / billing country

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magudelo62 magudelo62 requested a review from buskamuza as a code owner October 27, 2019 13:21
@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2019

Hi @magudelo62. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@osrecio osrecio self-assigned this Oct 27, 2019
@osrecio osrecio added partners-contribution Pull Request is created by Magento Partner Partner: Interactiv4 Pull Request is created by partner Interactiv4 labels Oct 27, 2019
@osrecio
Copy link
Member

osrecio commented Oct 27, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, here is your new Magento instance.
Admin access: https://pr-25313.instances.magento-community.engineering/admin
Login: admin Password: 123123q

osrecio
osrecio approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in my local environment and new region are usable.

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-6183 has been created to process this Pull Request
✳️ @osrecio, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Bravo engcom-Bravo self-assigned this Oct 28, 2019
@engcom-Bravo
Copy link
Contributor

Hello @osrecio. Would You please mark this issue with an appropriate label on Auto-Tests. Thank You.

@engcom-Bravo engcom-Bravo requested a review from osrecio November 1, 2019 10:02
@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 11, 2019
@ghost ghost assigned VladimirZaets Nov 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6183 has been created to process this Pull Request

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 21, 2019
@VladimirZaets VladimirZaets mentioned this pull request Nov 26, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Nov 26, 2019
@VladimirZaets
ENGCOM-6183: feature/25312 Add Colombian regions #25313
ff31a81
@magento-engcom-team magento-engcom-team merged commit a9f499e into magento:2.3-develop Nov 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2019

Hi @magudelo62, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@buskamuza buskamuza Awaiting requested review from buskamuza

@osrecio osrecio Awaiting requested review from osrecio

Assignees

@osrecio osrecio

@VladimirZaets VladimirZaets

@engcom-Bravo engcom-Bravo

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Directory Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
6 participants
@magudelo62 @osrecio @magento-engcom-team @engcom-Bravo @VladimirZaets @engcom-Foxtrot