Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct spelling #25328

Merged
merged 4 commits into from
Nov 27, 2019
Merged

Correct spelling #25328

merged 4 commits into from
Nov 27, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Oct 28, 2019 •
edited
Loading

Description (*)

Correct spelling

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2019

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Oct 28, 2019
@rodrigowebjump rodrigowebjump self-requested a review October 28, 2019 09:30
@rodrigowebjump rodrigowebjump self-assigned this Oct 28, 2019
rodrigowebjump
rodrigowebjump requested changes Oct 31, 2019
View reviewed changes
app/code/Magento/Sales/Model/ResourceModel/Status/Collection.php Outdated
@@ -1,6 +1,6 @@
<?php
/**
* Oder statuses grid collection
* Order status grid collection
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this description just before the class name.
See \Magento\Sales\Model\ResourceModel\Order\Invoice.php

@VladimirZaets VladimirZaets added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Nov 25, 2019
@VladimirZaets VladimirZaets self-assigned this Nov 25, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6333 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Nov 26, 2019
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 26, 2019
@ghost ghost added the Progress: accept label Nov 26, 2019
magento-engcom-team pushed a commit that referenced this pull request Nov 27, 2019
@VladimirZaets
ENGCOM-6333: Correct spelling #25328
10ec987
@magento-engcom-team magento-engcom-team merged commit b7d1359 into magento:2.3-develop Nov 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigowebjump rodrigowebjump rodrigowebjump requested changes

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@YevSent YevSent Awaiting requested review from YevSent

Assignees

@rodrigowebjump rodrigowebjump

@VladimirZaets VladimirZaets

@engcom-Bravo engcom-Bravo

@engcom-Foxtrot engcom-Foxtrot

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Sales Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
7 participants
@ravi-chandra3197 @magento-engcom-team @engcom-Bravo @rodrigowebjump @VladimirZaets @dmytro-ch @engcom-Foxtrot