Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAGETWO-98251 Position remove icon in sidebar #25380

Merged
merged 8 commits into from
Nov 15, 2019
Merged

MAGETWO-98251 Position remove icon in sidebar #25380

merged 8 commits into from
Nov 15, 2019

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Oct 30, 2019 •
edited
Loading

Description (*)

Remove icon that appears in Wishlist in sidebar receives line-height and width (each 35px) from listings.less what in the end changes its position. I unset line-height and set width to auto in module.less file in order to keep sidebar css changes related to product list in sidebar in one location. Other approach is to add :not(.sidebar) to listings.less.

Fixed Issues (if relevant)

  1. The Wishlist removing icon isn't correctly positioned on category pages #21190: The Wishlist removing icon isn't correctly positioned on category pages

Manual testing scenarios (*)

After changes:
image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 30, 2019

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ptylek
Copy link
Contributor Author

ptylek commented Oct 30, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ptylek
Copy link
Contributor Author

ptylek commented Oct 31, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ptylek
Copy link
Contributor Author

ptylek commented Oct 31, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your Magento instance.
Admin access: https://i-25380-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ptylek
Copy link
Contributor Author

ptylek commented Oct 31, 2019

Fixed in Blank and Luma

@ptylek ptylek requested a review from krzksz October 31, 2019 13:31
@ptylek ptylek changed the title MAGETWO-98251 Position remove icon in sidebar wishlist MAGETWO-98251 Position remove icon in sidebar Oct 31, 2019
@ghost ghost assigned aleron75 Nov 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ptylek
Copy link
Contributor Author

ptylek commented Nov 7, 2019

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-25380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ptylek
Copy link
Contributor Author

ptylek commented Nov 7, 2019 •
edited
Loading

@engcom-Alfa I fixed that issue.

image

@aleron75
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @aleron75. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, here is your new Magento instance.
Admin access: https://pr-25380.instances.magento-community.engineering/admin
Login: admin Password: 123123q

aleron75
aleron75 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@aleron75 aleron75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, good job

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-6233 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 14, 2019
@VladimirZaets VladimirZaets mentioned this pull request Nov 15, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Nov 15, 2019
@VladimirZaets
ENGCOM-6233: MAGETWO-98251 Position remove icon in sidebar #25380
c37c7e9
@magento-engcom-team magento-engcom-team merged commit 39988a1 into magento:2.3-develop Nov 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 15, 2019

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 15, 2019
This was referenced Mar 26, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleron75 aleron75 aleron75 approved these changes

@krzksz krzksz krzksz approved these changes

Assignees

@aleron75 aleron75

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3 Squashtoberfest 2019
Projects
None yet
Milestone
Release: 2.3.5
Development

Successfully merging this pull request may close these issues.
6 participants
@ptylek @magento-engcom-team @engcom-Alfa @aleron75 @krzksz @engcom-Foxtrot