Fix inability to place PayPal guest order when Automatic Assignment to Customer Group is enabled

[xylodev]

One of our shops reported that customers are unable to place a guest orders using the PayPal Express payment method. After some investigation it found out that this issue is caused by wiping out the customer email address from the quote model during the automatic assignment to the customer group. Moreover, the inability of placing the order is the case only when the PayPal is triggered from the cart by clicking "Checkout with PayPal" button. When one tries to make a guest order using PayPal in the payment method step in the checkout, the order is placed correctly due to the obvious reason, the e-mail address is explicitly set by the buyer during the 1st step of the checkout and thus it is correctly propagated to the corresponding customer object. This isn't the case when PayPal is started from the cart level.

Description (*)

This PR implements setting an e-mail address on the customer object assigned to quote, which is prepared for the furthr processing by PayPal module when the checkout is recognized as a guest one. The e-mail address is set only when the corresponding customer object doesn't have it set yet.

Fixed Issues (if relevant)

1. Fixes Unable to place a guest order with PayPal Express when Enable Automatic Assignment to Customer Group is enabled #25399 : Unable to place a guest order with PayPal Express when Enable Automatic Assignment to Customer Group is enabled

Manual testing scenarios (*)

1. Configure and enable PayPal Express payment method, especially make sure that the button is shown in the cart
2. In the Magento admin configuration, go to Customers > Customer Configuration and set Enable Automatic Assignment to Customer Group to Yes
3. Make sure you are NOT logged in to your Magento customer account
4. Put any product to the cart and go to the cart page
5. Click "Checkout with PayPal" button, next login to your PayPal account and select payment instrument
6. Once you are redirected back to the order review page, select a shipping method and click "Place Order" button
7. The expected result is the order success page and the payment correctly processed by PayPal

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @xylodev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[xylodev]

@magento give me test instance

[magento-engcom-team]

Hi @xylodev. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @xylodev, here is your new Magento instance.
Admin access: https://pr-25405.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[xylodev]

I can confirm that the issue is resolved on the provided test instance

[aleron75]

Hello @xylodev thank you for your contribution!

Due to Magento Definition of Done all code must be covered by tests.

For this specific case, you should cover your fix by automated tests with the scenario which leads to an issue. Tests should fail on the mainline and pass with your fix.

A starting point could be extending the \Magento\Paypal\Test\Unit\Model\Express\CheckoutTest.

Thank you again!

[askmikeyd]

I was having the same issue and I don't think the proposed solution is the way to go. This only solves it for Paypal but this issue exists when using other payment methods as a guest. A better solution needs to be done in the Magento Core. My fix for it was to set "Enable Automatic Assignment to Customer Group" to "Yes" at the website level as that is where my customer is created and set it to "No" at the store level which is what is checked when placing a guest order.

[sidolov]

@xylodev do you have plans to cover another checkout scenario? Looks like the issue is fixed for PayPal only.

[xylodev]

@sidolov I will review this issue next week and, depending on the review outcome, I will try to provide more general fix with the test coverage

[sidolov]

Waiting for additional coverage of all scenarios.

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @gabrieldagama, thank you for the review.
ENGCOM-8173 has been created to process this Pull Request

[engcom-Alfa]

@magento give me test instance

[magento-deployment-service]

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Alfa, here is your Magento Instance: https://b801cb7a66756698c11b87bf4cae4b72.instances.magento-community.engineering
Admin access: https://b801cb7a66756698c11b87bf4cae4b72.instances.magento-community.engineering/admin_298c
Login: 6ec6956f
Password: 45bb64472e71

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Configure and enable PayPal Express payment method, especially make sure that the button is shown in the cart;
2. In the Magento admin configuration, go to Customers > Customer Configuration and set Enable Automatic Assignment to Customer Group to Yes;
3. Make sure you are NOT logged in to your Magento customer account;
4. Put any product to the cart and go to the cart page;
5. Click the "Checkout with PayPal" button, next login to your PayPal account, and select payment instrument;
6. Once you are redirected back to the order review page, select a shipping method and click the "Place Order" button;

Before: ✖️ The payment is processed successfully on PayPal gateway, but the order is not created in Magento because of "Failed address validation: %1" error

After: ✔️ The payment correctly processed by PayPal and the order is successfully created

Also, was tested with disabled Automatic Assignment to Customer Group, placing an order from payment method step, from the cart page and everything works as expected.

[m2-assistant]

Hi @xylodev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.