Telephone Widget > Template > Removing this and helper

[rafaelstz]

Description (*)

I provided this PR to fix the issue that I had in the PR #25321, to follow the Magento Coding Standards I'm removing the helper and $this from the template file.
I used a method in block class to enable me to do it instead of calling the helper directly in the template file. I created a new method as well to get the telephone validation directly as this class and phtml are dedicated to the telephone widget.

Fixed Issues (if relevant)

1. helper and $this into the template file

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rafaelstz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[VladimirZaets]

Hi @rafaelstz. Thanks for collaboration. Please take a look at my review comment.

[VladimirZaets]

Why we need this method? We can use directly $this->getAttributeValidationClass('telephone').

[rafaelstz]

Hi @VladimirZaets
I pushed a fix to merge the two similar methods, as we are using this class just for the telephone widget template, I think the validation method can be specific and already set the validation class required to the telephone attribute.
What do you think?

[VladimirZaets]

Hi @VladimirZaets
I pushed a fix to merge the two similar methods, as we are using this class just for the telephone widget template, I think the validation method can be specific and already set the validation class required to the telephone attribute.
What do you think?

Hi @rafaelstz. First of all, we can't change the interface of the public method because it's backward-incompatible changes. You are right, in magento we use this class just for telephone widget template, but our extension developers and customers can use/extend this class in they implementations and your fix can break them.

[rafaelstz]

Hi @VladimirZaets, I've updated the pull-request to avoid backward-incompatibility.

[VladimirZaets]

This functionality is already covered by integration test.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6332 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @rafaelstz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.