Cleanup, refactor and cover with tests section-config module

[krzksz]

Description (*)

I decided to create this PR as a follow up to my previous attempt at fixing errors that were caused by 3rd party modules doing POST requests or requesting customer data directly before the module was initialized by data-mage-init.

I also added unit tests for all the public methods and to make sure no errors are thrown if some code incorrectly calls the module before is has a chance to initialize.

Fixed Issues (if relevant)

1. x-magento-init initialisation not bound to happen in the right order. #17125: x-magento-init initialisation not bound to happen in the right order.

Manual testing scenarios (*)

1. Reload the shop.
2. Trigger customer data or sections data module at the very beginning for example by running the following code:

require(['Magento_Customer/js/section-config'], function(sectionsConfig) {
    console.log(sectionsConfig.getAffectedSections('test'));
});

3. TypeError: sections is undefined is being thrown without this changes.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @krzksz,
Please check functional tests failures, looks like your changes break some functionality.

[krzksz]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @krzksz. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @krzksz, here is your Magento instance.
Admin access: https://i-25764-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[krzksz]

@magento run all tests

[magento-engcom-team]

Hi @ptylek, thank you for the review.
ENGCOM-6666 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[omiroshnichenko]

1 tiny comment, but everything else looks good. Thank you for cleanup and especially for covering it with the unit test.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-6666 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[engcom-Kilo]

Functional tests CE - not successful on remote test server,
but not depends by changes in Pull Request.
Remote Test server - with some fails with Create test data.

[m2-assistant]

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.