-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #26083 - problem with unsAdditionalInformation in \Magento\Payment\Model\Info #26084
Fix #26083 - problem with unsAdditionalInformation in \Magento\Payment\Model\Info #26084
Conversation
Hi @marcoaacoliveira. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hello @marcoaacoliveira, thanks for your contribution. Due to Magento Definition of Done all code must be covered by tests. For this specific case, you should cover your fix by automated tests with the scenario which leads to the issue: tests should fail on the mainline and pass with your fix. To answer the question "which kind of tests should I write", the answer is: Thanks again! |
@aleron75 thanks for reviewing, I'll work on it. |
Hi @aleron75, thank you for the review. |
@marcoaacoliveira thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
✔️ QA passed |
…agento\Payment\Model\Info #26084
Hi @marcoaacoliveira, thank you for your contribution! |
Description (*)
Fix problem with unsAdditionalInformation method in \Magento\Payment\Model\Info, it wasn't init data properly.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)