Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue 25910 choose drop down not close when open another #26090

Merged
merged 5 commits into from
Feb 26, 2020
Merged

Fixed issue 25910 choose drop down not close when open another #26090

merged 5 commits into from
Feb 26, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Dec 18, 2019 •
edited
Loading

Description (*)

This PR fixed #25910: issue
2020-01-29 16 09 12

Fixed Issues (if relevant)

  1. magento/magento2 Choose drop down not close when open another for upload file for swatch #25910: Choose drop down not close when open another for upload file for swatch

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@Usik2203 Usik2203 requested a review from DrewML as a code owner December 18, 2019 09:41
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 18, 2019
@Usik2203 Usik2203 closed this Jan 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 14, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Usik2203 Usik2203 reopened this Jan 14, 2020
@Usik2203 Usik2203 closed this Jan 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Usik2203 Usik2203 reopened this Jan 20, 2020
@Usik2203 Usik2203 closed this Jan 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Usik2203 Usik2203 reopened this Jan 20, 2020
@Usik2203 Usik2203 closed this Jan 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Usik2203 Usik2203 reopened this Jan 20, 2020
@Usik2203 Usik2203 requested a review from rogyar February 7, 2020 17:13
@rogyar rogyar self-assigned this Feb 9, 2020
rogyar
rogyar requested changes Feb 9, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203. Thank you for the fix. According to the last updates to the definition of done all changes should be covered by automated tests. Could I kindly ask you to cover your changes by MFTF test?

Thank you.

@Usik2203
Copy link
Contributor Author

Hi, @rogyar
I covered my fix by MFTF test.
Thanks for Your advice.

@Usik2203
Copy link
Contributor Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-26090.instances.magento-community.engineering/admin_b532
Login: f29f43f8 Password: 0cda837296e1
Instance will be terminated in up to 3 hours.

rogyar
rogyar previously requested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Usik2203. Thank you for providing the test. The current version of the test emulates swatch clicking behavior. However, It does not perform any checks (assertions).
Your test should assert that after clicking on a new swatch the previous dropdown is not visible.

@ghost ghost dismissed rogyar’s stale review February 21, 2020 15:24

Pull Request state was updated. Re-review required.

@engcom-Echo engcom-Echo self-assigned this Feb 24, 2020
@Usik2203
Copy link
Contributor Author

Hi @rogyar
I have added some assertions for this test
Thank you for Your advice.

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage labels Feb 24, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6966 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Feb 25, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 26, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 26, 2020
@slavvka
ENGCOM-6966: Fixed issue 25910 choose drop down not close when open a…
c509eb9 
…nother #26090
@magento-engcom-team magento-engcom-team merged commit cacdfaf into magento:2.4-develop Feb 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@DrewML DrewML Awaiting requested review from DrewML

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choose drop down not close when open another for upload file for swatch
5 participants
@Usik2203 @magento-engcom-team @engcom-Delta @rogyar @engcom-Echo