Fixed 24990: link doesn't redirect to dashboard #26100

Usik2203 · 2019-12-18T15:27:51Z

Description (*)

This PR fixed #24990 issue

Fixed Issues (if relevant)

Admin Panel logo link is not directing to admin dashboard page #24990: Admin Panel logo link is not directing to admin dashboard page

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2019-12-18T15:27:54Z

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

Usik2203 · 2019-12-18T15:29:09Z

@magento give me test instance

magento-engcom-team · 2019-12-18T15:29:13Z

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-12-18T15:29:55Z

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-26100.instances.magento-community.engineering/admin
Login: admin Password: 123123q

lbajsarowicz · 2019-12-18T21:13:50Z

setup/src/Magento/Setup/Controller/Navigation.php

    /**
     * @param NavModel $navigation
     * @param Status $status
     */
-    public function __construct(NavModel $navigation, Status $status)
+    public function __construct(NavModel $navigation, Status $status, ObjectManagerProvider $objectManagerProvider)


Why do you use ObjectManagerProvider instead of injecting just UrlInterface?

I am getting such error "An error occurred during execution; please try again later" and status 500 while injecting UrlInterface directly in constructor of controller

m2-assistant · 2020-01-14T18:22:30Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Usik2203 · 2020-01-30T11:10:57Z

@magento give me test instance

magento-engcom-team · 2020-01-30T11:11:02Z

Hi @Usik2203. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2020-01-30T11:11:45Z

Hi @Usik2203, here is your new Magento instance.
Admin access: https://pr-26100.instances.magento-community.engineering/admin_fbea
Login: a8bacc76 Password: 98beb8e12485
Instance will be terminated in up to 3 hours.

lbajsarowicz

Instantiation of the classes with new keyword
Use of Object Manager.

lbajsarowicz · 2020-01-30T12:41:34Z

setup/src/Magento/Setup/Controller/Navigation.php

@@ -57,7 +59,7 @@ public function __construct(NavModel $navigation, Status $status, ObjectManagerP
     */
    public function indexAction()
    {
-        $json = new JsonModel;
+        $json = new JsonModel();


Why are you instantiating classes with new instead of using Factory or just Dependency Injection?

lbajsarowicz · 2020-01-30T12:41:58Z

setup/src/Magento/Setup/Controller/Navigation.php

-        /** @var \Magento\Backend\Model\UrlInterface $backendUrl */
-        $backendUrl = $this->objectManagerProvider->get()->get(\Magento\Backend\Model\UrlInterface::class);
+        /** @var UrlInterface $backendUrl */
+        $backendUrl = $this->objectManagerProvider->get()->get(UrlInterface::class);


You should inject that class to the constructor.

Hi @lbajsarowicz ,
Unfortunately I can't inject \Magento\Backend\Model\UrlInterfacedirectly to constructor. I get such error.

Also I want to notice that construction like this $this->objectManagerProvider->get() is used in a lot of cases.

If such approach is wrong, maybe You could advise me something ?

Thanks a lot!

lbajsarowicz · 2020-01-30T12:42:04Z

setup/src/Magento/Setup/Controller/Navigation.php

@@ -47,7 +49,7 @@ public function __construct(NavModel $navigation, Status $status, ObjectManagerP
        $this->navigation = $navigation;
        $this->status = $status;
        $this->objectManagerProvider = $objectManagerProvider;
-        $this->view = new ViewModel;
+        $this->view = new ViewModel();


Why are you instantiating classes with new instead of using Factory or just Dependency Injection?

I cannot create through Factory or Dependency Injection as usual I am getting such error

Also I see a lot of cases in setup/src/Magento/Setup/Controller were these object was created with new

Usik2203 · 2020-03-26T15:12:51Z

Hi @lbajsarowicz .
Do You have any news about this PR?
Thanks

eduard13

Hi @Usik2203, could you please fix the conflicting file?
Thank you.

lbajsarowicz · 2020-04-01T08:31:07Z

Sorry, I've tried to unassign me from the PR.

magento-engcom-team · 2020-04-01T12:18:37Z

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7237 has been created to process this Pull Request

m2-assistant · 2020-04-02T04:27:46Z

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Fixed 24990 link not to redirect to dashboard

5a5091c

Usik2203 requested a review from buskamuza as a code owner December 18, 2019 15:27

magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 18, 2019

lbajsarowicz suggested changes Dec 18, 2019

View reviewed changes

ghost assigned lbajsarowicz Dec 18, 2019

ghost added the Progress: needs update label Dec 18, 2019

Usik2203 closed this Jan 14, 2020

Usik2203 reopened this Jan 14, 2020

ghost unassigned lbajsarowicz Jan 14, 2020

Fixed codeStyle issues

1818eaf

lbajsarowicz suggested changes Jan 30, 2020

View reviewed changes

ghost assigned lbajsarowicz Jan 30, 2020

Usik2203 added 3 commits February 3, 2020 18:41

fixed classes with new keyword

c98e03f

Fixed Code style issues

8c672eb

Fix issue with UnitTests

b90f20c

Usik2203 requested a review from eduard13 February 18, 2020 16:39

Usik2203 requested a review from lbajsarowicz February 28, 2020 09:07

eduard13 requested changes Mar 27, 2020

View reviewed changes

ghost assigned eduard13 Mar 27, 2020

ghost added the Progress: extended testing label Apr 1, 2020

lbajsarowicz removed their assignment Apr 1, 2020

lbajsarowicz requested review from lbajsarowicz and removed request for lbajsarowicz April 1, 2020 08:30

engcom-Echo self-assigned this Apr 1, 2020

engcom-Echo requested review from lbajsarowicz and removed request for lbajsarowicz April 1, 2020 12:14

lbajsarowicz approved these changes Apr 1, 2020

View reviewed changes

ghost assigned lbajsarowicz Apr 1, 2020

ghost added Progress: ready for testing and removed Progress: extended testing labels Apr 1, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 1, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Apr 1, 2020

ghost added Progress: accept and removed Progress: extended testing labels Apr 1, 2020

magento-engcom-team mentioned this pull request Apr 2, 2020

Admin Panel logo link is not directing to admin dashboard page #24990

Closed

magento-engcom-team pushed a commit that referenced this pull request Apr 2, 2020

ENGCOM-7237: Fixed 24990: link doesn't redirect to dashboard #26100

d086d3a

magento-engcom-team merged commit 2d42bfc into magento:2.4-develop Apr 2, 2020

sdzhepa mentioned this pull request May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed 24990: link doesn't redirect to dashboard #26100

Fixed 24990: link doesn't redirect to dashboard #26100

Usik2203 commented Dec 18, 2019

m2-assistant bot commented Dec 18, 2019

Usik2203 commented Dec 18, 2019

magento-engcom-team commented Dec 18, 2019

magento-engcom-team commented Dec 18, 2019

lbajsarowicz Dec 18, 2019

Usik2203 Jan 8, 2020 •

edited

Loading

m2-assistant bot commented Jan 14, 2020

Usik2203 commented Jan 30, 2020

magento-engcom-team commented Jan 30, 2020

magento-engcom-team commented Jan 30, 2020

lbajsarowicz left a comment

lbajsarowicz Jan 30, 2020

lbajsarowicz Jan 30, 2020

Usik2203 Feb 3, 2020

lbajsarowicz Jan 30, 2020

Usik2203 Feb 3, 2020 •

edited

Loading

Usik2203 commented Mar 26, 2020

eduard13 left a comment •

edited

Loading

lbajsarowicz commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

m2-assistant bot commented Apr 2, 2020

Fixed 24990: link doesn't redirect to dashboard #26100

Fixed 24990: link doesn't redirect to dashboard #26100

Conversation

Usik2203 commented Dec 18, 2019

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Dec 18, 2019

Usik2203 commented Dec 18, 2019

magento-engcom-team commented Dec 18, 2019

magento-engcom-team commented Dec 18, 2019

lbajsarowicz Dec 18, 2019

Choose a reason for hiding this comment

Usik2203 Jan 8, 2020 • edited Loading

Choose a reason for hiding this comment

m2-assistant bot commented Jan 14, 2020

Usik2203 commented Jan 30, 2020

magento-engcom-team commented Jan 30, 2020

magento-engcom-team commented Jan 30, 2020

lbajsarowicz left a comment

Choose a reason for hiding this comment

lbajsarowicz Jan 30, 2020

Choose a reason for hiding this comment

lbajsarowicz Jan 30, 2020

Choose a reason for hiding this comment

Usik2203 Feb 3, 2020

Choose a reason for hiding this comment

lbajsarowicz Jan 30, 2020

Choose a reason for hiding this comment

Usik2203 Feb 3, 2020 • edited Loading

Choose a reason for hiding this comment

Usik2203 commented Mar 26, 2020

eduard13 left a comment • edited Loading

Choose a reason for hiding this comment

lbajsarowicz commented Apr 1, 2020

magento-engcom-team commented Apr 1, 2020

m2-assistant bot commented Apr 2, 2020

Usik2203 Jan 8, 2020 •

edited

Loading

Usik2203 Feb 3, 2020 •

edited

Loading

eduard13 left a comment •

edited

Loading