-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refund notification registration #2656
Conversation
Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. Until then, can you please sign the contributor license agreement? |
hello @schurter-cw, can you please update code of the PR and cover it by Travis tests? |
Hi @Vinai Could you please accept the pull request from @schurter-cw this will solve issues for us as well. It is difficult to create a credit memo programmatically because the prepareCreditMemo is a protected function what is the best method to use ? Regards, |
@NadiyaS Could you look at my question above ? |
The travis build is still disabled? Our build server gives this message:
@schurter-cw perhaps you should also update the test in your PR. |
Hi @schurter-cw, @rikterbeek |
The fix has been delivered to develop branch. |
[TSG] Upporting for 2.3 (pr21) (2.3.0)
The
registerRefundNotification(...)
method tries to register a credit memo, but theregister()
method does not longer exist in the\Magento\Sales\Model\Order\Creditmemo
class.