Skip to content

Fix hard-code scope store string #26926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 10, 2020
Merged

Fix hard-code scope store string #26926

merged 8 commits into from
Apr 10, 2020

Conversation

@mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Feb 19, 2020 •
edited
Loading

Description (*)

Clean up string scope store and also clean up file test

Related Pull Requests

Fixed Issues (if relevant)

  1. No issue available

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned omiroshnichenko Feb 19, 2020
@engcom-Alfa engcom-Alfa self-assigned this Feb 20, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 20, 2020

Hi, @mrtuvn. Could you fix failing tests?
Thanks!

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 20, 2020

Hi @omiroshnichenko.
Could you review the latest changes? Thanks!

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Feb 20, 2020 •
edited
Loading

Hi, @mrtuvn. Could you fix failing tests?
Thanks!

@engcom-Alfa i have fixed test
@omiroshnichenko can you review again

@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 21, 2020
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Feb 21, 2020

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Feb 21, 2020
@engcom-Charlie engcom-Charlie removed their assignment Feb 25, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Mar 9, 2020

also this PR quite long response ! Should i need extra test

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 2, 2020

Can we have new process on this

@ghost ghost dismissed omiroshnichenko’s stale review April 7, 2020 18:43

Pull Request state was updated. Re-review required.

@ghost ghost removed the Progress: accept label Apr 7, 2020
@ghost ghost assigned VladimirZaets Apr 8, 2020
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Apr 8, 2020

Hi @VladimirZaets, thank you for the review.
ENGCOM-7282 has been created to process this Pull Request

@VladimirZaets VladimirZaets added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. and removed Release Line: 2.4.1 labels Apr 8, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 8, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 10, 2020
@slavvka
ENGCOM-7282: Fix hard-code scope store string #26926
587ecb4
@magento-engcom-team magento-engcom-team merged commit bf015b7 into magento:2.4-develop Apr 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the fix/hard-code-scope-store-customer-email-notification branch June 7, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

+1 more reviewer

@omiroshnichenko omiroshnichenko omiroshnichenko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@VladimirZaets VladimirZaets

@omiroshnichenko omiroshnichenko

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

7 participants

@mrtuvn @engcom-Alfa @magento-engcom-team @VladimirZaets @omiroshnichenko @engcom-Charlie @slavvka