Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for images in system.xml with config_path #2706

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Fix for images in system.xml with config_path #2706

merged 1 commit into from
Mar 2, 2016

Conversation

gonzaloebiz
Copy link
Contributor

In the system.xml if you put a field of type="image" and specify a config_path like this:

Popup Image
<backend_model>Magento\Config\Model\Config\Backend\Image</backend_model>
<upload_dir config="system/filesystem/media" scope_info="1">sales/payment/ebizmarts</upload_dir>
<base_url type="media" scope_info="1">sales/payment/ebizmarts</base_url>
<config_path>payment/ebizmarts/popup_image</config_path>

that not works.
This patch fix this

@Vinai
Copy link
Contributor

Vinai commented Dec 15, 2015

Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. In the mean time, can you please sign the contributor license agreement?

@gonzaloebiz
Copy link
Contributor Author

Done, the license agreement is signed

@mazhalai
Copy link
Contributor

@gonzaloebiz Please merge latest from develop and rerun builds.

@dsikkema-magento
Copy link
Contributor

@gonzaloebiz could you go ahead an re-launch the builds please, after merging latest?
Internal ticket created: MAGETWO-49872

@dsikkema-magento dsikkema-magento added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 26, 2016
@gonzaloebiz
Copy link
Contributor Author

Sorry i don't understand what you want, can you explain it?

@Zatara7
Copy link

Zatara7 commented Feb 29, 2016

@gonzaloebiz what dskikema meant is to merge latest code from develop branch of magento2 and push it to your branch that you started the PR from. This will trigger the Travis CI builds "continuous-integration/travis-ci/pr"

@magento-team magento-team merged commit 22f21d2 into magento:develop Mar 2, 2016
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2018
…-Category

[architects] MAGETWO-92773: [GraphQL] Products cannot be fetched in parent/anchor category #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants