Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - CHANGELOG.md is reporting the incorrect issue links #27087

Closed

Conversation

ansari-ziyaurrahman
Copy link
Contributor

Fixed - CHANGELOG.md is reporting the incorrect issue links #27049

Description (*)

Fixed - CHANGELOG.md is reporting the incorrect issue links #27049

Fixed Issues (if relevant)

  1. CHANGELOG.md is reporting the incorrect issue links (I expect to see this in the changelog) #27049: Fixed - CHANGELOG.md is reporting the incorrect issue links CHANGELOG.md is reporting the incorrect issue links (I expect to see this in the changelog) #27049

Manual testing scenarios (*)

  1. check 2.3.4 changelog for Fatal error: Class 'Mage' not found #167 it redirect to wrong Issue

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 29, 2020

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@lbajsarowicz
Copy link
Contributor

@magento run all tests

@hostep
Copy link
Contributor

hostep commented Feb 29, 2020

@ansari-krish: this one line fix is not enough, there are a bunch more incorrect lines:

#773 -- problem jquery (fixed in magento/graphql-ce#797)
#271 -- Check Data should validate gallery information (fixed in magento/graphql-ce#489)
#815 -- Installation is incomplete. Check the console log for errors before trying again. (Windows 7 WAMP) (fixed in magento/graphql-ce#842)
...

We should also try to figure out how this file gets generated, I'm assuming some kind of script is used for this but I'm not sure if it will be in this repository, if a script is being used, the correct fix here would be to fix the script and then generate that file again.

@lbajsarowicz: do you happen to know more about this? Or do you know somebody inside Magento who can help explain this further? @sdzhepa maybe?

@lbajsarowicz
Copy link
Contributor

@hostep That's actually good point from your side.
Let me call @VladimirZaets - maybe he'll be able to provide the solution.

@engcom-Alfa
Copy link
Contributor

@magento run all tests

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Mar 3, 2020
@p-bystritsky p-bystritsky changed the base branch from 2.3 to 2.4-develop March 3, 2020 09:14
@engcom-Charlie engcom-Charlie changed the base branch from 2.4-develop to 2.3 March 3, 2020 09:24
@lenaorobei
Copy link
Contributor

@ansari-krish CHANGELOG.md is being generated by our internal tools.
I created a task to address this issue. Unfortunately 2.3.x release line is not publicly available so I need to close this PR. We will fix it internally taking all wrong links into account.

@lenaorobei lenaorobei closed this Mar 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2020

Hi @ansari-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ansari-ziyaurrahman ansari-ziyaurrahman deleted the patch-27049 branch March 5, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants