Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Report date doesn't matching in configuration setting #27088

Merged
merged 4 commits into from
Mar 27, 2020

Conversation

Priya-V-Panchal
Copy link

Description (*)

Report Value doesn't matching - "Year-To-Date Starts" in reports configuration

Fixed Issues (if relevant)

  1. Report Value doesn't matching - "Year-To-Date Starts" #27086: Report Value doesn't matching - "Year-To-Date Starts"

Manual testing scenarios (*)

  1. Login to Adminpanel.
  2. Go to Stores >> Configuration >> General >> Reports
  3. From Dashboard tab >> Select "Year-To-Date Starts".

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 29, 2020

Hi @Priya-V-Panchal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@eduard13 eduard13 self-assigned this Mar 1, 2020
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Priya-V-Panchal. Thank you for your contribution. According to the last updates to the definition of done all changes should be covered by automated tests.
Could I kindly ask you to cover your changes by an MFTF test?

Thank you.

@eduard13
Copy link
Contributor

Hi @Priya-V-Panchal, are you willing to continue working on this one?

@eduard13 eduard13 added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Mar 10, 2020
@engcom-Charlie engcom-Charlie self-assigned this Mar 15, 2020
@engcom-Charlie engcom-Charlie requested a review from eduard13 March 16, 2020 14:15
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you @engcom-Charlie for the adjustments.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7110 has been created to process this Pull Request

@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Mar 16, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@m2-assistant
Copy link

m2-assistant bot commented Mar 27, 2020

Hi @Priya-V-Panchal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants