Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #27099 - Newsletter Input width issue #27106

Merged
merged 3 commits into from
Jun 13, 2020
Merged

Fixed issue #27099 - Newsletter Input width issue #27106

merged 3 commits into from
Jun 13, 2020

Conversation

dipeshrangani
Copy link
Contributor

@dipeshrangani dipeshrangani commented Feb 29, 2020 •
edited by engcom-Echo
Loading

Newsletter Input width issue.

Preconditions (*)

Magento 2.3.4

  1. When enter wrong email input width increased.

Reference issue (*)

Fixed #27099

Steps to reproduce (*)

  1. Enter invalid email address in footer newletter.

Expected result (*)

image

Actual result (*)

image

@m2-assistant
Copy link

m2-assistant bot commented Feb 29, 2020

Hi @dipeshrangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Feb 29, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 29, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-27106.instances.magento-community.engineering/admin_c560
Login: c088de8d Password: 8e8b50a57e59
Instance will be terminated in up to 3 hours.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 29, 2020
rogyar
rogyar previously approved these changes Feb 29, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7010 has been created to process this Pull Request

@dipeshrangani dipeshrangani changed the title Fixed issue - 27099 Fixed issue #27099 - Newsletter Input width issue Mar 2, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 2, 2020
engcom-Alfa
engcom-Alfa requested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dipeshrangani.
Could you fix it and for the Blank theme in the scope of this PR?
Thanks!

@ghost ghost dismissed rogyar’s stale review March 2, 2020 09:01

Pull Request state was updated. Re-review required.

@dipeshrangani
Copy link
Contributor Author

Hi @engcom-Alfa, I have fixed this issue in blank theme as well.
Please review.

@sdzhepa sdzhepa linked an issue Apr 30, 2020 that may be closed by this pull request
Newsletter Input width issue. #27099
Closed
@sdzhepa sdzhepa added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7010 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
Luma theme
Peek 2020-05-12 10-30

Blank theme
Peek 2020-05-12 10-33

After:
Luma theme
Peek 2020-05-12 10-47

Blank theme
Peek 2020-05-12 10-43

Tested on desktop, mobile, and tablets.

@slavvka slavvka added this to the 2.4.1 milestone May 12, 2020
@VladimirZaets VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 19, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 11, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jun 13, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2020
@slavvka
ENGCOM-7010: Fixed issue - 27099 #27106
b3e466d
@magento-engcom-team magento-engcom-team merged commit 1d4862f into magento:2.4-develop Jun 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @dipeshrangani, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Newsletter Input width issue.
8 participants
@dipeshrangani @rogyar @magento-engcom-team @engcom-Alfa @sdzhepa @VladimirZaets @slavvka @engcom-Echo