Fix bug 26449: Configurable product attribute issue

[tna274]

Description (*)

Fix bug 26449: when creating a new configurable product, configuration options attribute of parent product still have value

Related Pull Requests

N/A

Fixed Issues (if relevant)

1. Fixes Configurable product attribute issue #26449: Configurable product attribute issue

Manual testing scenarios (*)

1. Log into the admin account.
2. Navigate to Catalog > Products.
3. In add new product dropdown choose configurable product and create a configurable product using “Size” attribute:-
4. One of those variants value('Size') must be set default

3. After saving product, the value of "Size" attribute will be set null

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @tna274. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[edenduong]

Hi @tna274 : Please check the Unit Test. It is failed now. Please run vendor/bin/phpunit app/code/Magento/ConfigurableProduct/Test/Unit/Plugin/Model/ResourceModel/ProductTest.php to check the error of Unit Test. Thanks.

[tna274]

Hi @edenduong
I have updated code to fix the unit test

[edenduong]

Method $object->setData($optionAttribute->getAttributeCode(), null); (and the logic in if block) is not covered by Unit Test. Please mockupgetExtensionAttributes , to cover the if block.
Thank you.

[tna274]

Hi @edenduong
I have updated unit test

[edenduong]

Hi @tna274 : Please check my comment

• Remove redundant code
• use instead of full class name
• Mock object should be declare as postfix mock like searchCriteriaBuilderMock

[engcom-Echo]

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7214 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Go to Admin->Catalog->Products->Add Configurable Product;
2. Fill all required fields and click on Create Configurations->Create New Attribute;
3. Create text swatch attribute "Size" and set value s -> Is Default;
   
   
4. Save Attribute and go to the next step;
5. Select all options expect s (default);
   
6. Generate products and Save product
   
7. Go to Storefront -> category with created before product;

Before:
✖️ S Size assigned parent configurable product automatically and visible in filter result on category page when user select size S. That is the wrong functionality.

After:
✔️ Size attribute assigned to parent configurable product, so once user filter the product on a category page using S size, this product does not show in filter result.

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @tna274, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.