Implement ActionInterface for /captcha/refresh #27381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Component: Captcha
Release Line: 2.4
Partner: Mediotype
partners-contribution
ihor-sviziev
added
improvement
Auto-Tests: Covered
ihor-sviziev
requested changes
Mar 21, 2020
There was a problem hiding this comment.
Hi @lbajsarowicz,
Please fix static tests.
There were also failing functional test related to not closed loading mask on all versions (I never saw it earlier), so I restarted functional tests
|
@magento run Functional Tests B2B |
ihor-sviziev
approved these changes
Mar 21, 2020
|
Hi @ihor-sviziev, thank you for the review. |
4 tasks
ghost
added
Progress: testing in progress
and removed
Progress: ready for testing
labels
|
✔️ QA Passed |
ghost
added
Progress: extended testing
and removed
Progress: testing in progress
labels
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 27, 2020
|
Hi @lbajsarowicz, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This is a part of the process of introducing implementations of
ActionInterface.Related Pull Requests
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
N/A
Questions or comments
Contribution checklist (*)