Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ActionInterface for wishlist/shared #27494

Merged
merged 20 commits into from
Aug 24, 2020

Conversation

dxx004
Copy link

@dxx004 dxx004 commented Mar 30, 2020

Description (*)

This is a part of the process of introducing implementations of ActionInterface.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Implement ActionInterface for wishlist/shared #29537: Implement ActionInterface for wishlist/shared

@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @dxx004. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Mar 30, 2020
@dxx004 dxx004 changed the title Refactor/wishlist Implement ActionInterface for wishlist Mar 30, 2020
@ihor-sviziev ihor-sviziev self-assigned this Mar 30, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests improvement labels Mar 30, 2020
@dxx004 dxx004 changed the title Implement ActionInterface for wishlist Implement ActionInterface for wishlist/shared Mar 30, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dxx004,
Could you review and fix static test failures?
Unit test failure seems to me not related to your changes

@ihor-sviziev
Copy link
Contributor

Hi @dxx004,
Will you be able to update your PR with requested changes?

@ihor-sviziev
Copy link
Contributor

@dxx004 I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@m2-assistant
Copy link

m2-assistant bot commented Apr 21, 2020

Hi @dxx004, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lbajsarowicz
Copy link
Contributor

@ihor-sviziev Reopening due to updates.

@lbajsarowicz lbajsarowicz reopened this May 13, 2020
@ihor-sviziev
Copy link
Contributor

@engcom-Charlie could you review and fix failing tests?

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@ihor-sviziev could you please review this PR?

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7779 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Login to a customer account and add a product to wishlist;
  2. Go to "wishlist" and click "Share wishlist";
  3. Enter email, message and send;
  4. Logout from the customer account;
  5. Open a shared wishlist email, Click on "View Product" from email;
  6. It landed on the shared wishlist products;
    Click on the "Add to Cart" button from any product.

Actual Result: ✔️ The product was added to cart

Screenshot from 2020-08-13 11-02-00

Click on the "Add All to Cart" button

Actual Result: ✔️ The products were added to cart

Screenshot from 2020-08-13 11-01-24

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 13, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@sidolov sidolov added the Priority: P3 May be fixed according to the position in the backlog. label Aug 17, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 21, 2020
@magento-engcom-team magento-engcom-team merged commit f9ad1c8 into magento:2.4-develop Aug 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 24, 2020

Hi @dxx004, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Wishlist improvement Partner: Blue Acorn iCi Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Issue] Implement ActionInterface for wishlist/shared
8 participants