PhpUnit 8 Migration - AdminNotification

[ihor-sviziev]

Description (*)

This PR updates unit tests in AdminNotification module + contains framework fix from #27519

Note:
We have 2 warnings that can't be fixed because these new methods doesn't exists in phpunit 6:

1) Magento\AdminNotification\Test\Unit\Model\System\Message\CacheOutdatedTest::testGetText
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

2) Magento\AdminNotification\Test\Unit\Model\System\Message\Media\Synchronization\ErrorTest::testGetText
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

Related Pull Requests

Fixed Issues (if relevant)

1. Unit Tests incompatible with PHPUnit 8 #27500

Manual testing scenarios (*)

1. Run tests in phpunit 6 (currently in 2.4-develop) using vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/AdminNotification/
2. Install phpunit 8, run tests using vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist app/code/Magento/AdminNotification/

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lbajsarowicz]

In future we can change the scope for Test properties from protected to private.
I'm not sure if it's for purpose or accidentally, but you've added changes from other PR.

You can put in the description that this PR would work after merging another (however the changes introduced in files related to AdminNotification are backward compatible, so there's no dependency)

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@lbajsarowicz
I fixed comments that you left. Why I put there one commit from framework - just to make these pull requests independent, as the same commit is there in al PRs - there will not be any conflicts between them and all of these PRs will actually work

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7243 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ihor-sviziev]

@lenaorobei seems like we have false positive in static test

[lenaorobei]

@ihor-sviziev looking into it.

[lenaorobei]

Yes, the 3-rd finding looks like false-positive, but it should disappear when first 2 will be fixed.

[lbajsarowicz]

Yes, I reviewed them before and was waiting for tests to pass.
We have all green, so my approval is there.

[magento-engcom-team]

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7243 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Preconditions:
PHPUnit v8.5.3
php 7.3

Before:

After:

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.