Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MFTF] Set correct url for CmsPageEditPage #27563

Merged
merged 2 commits into from
Apr 10, 2020
Merged

[MFTF] Set correct url for CmsPageEditPage #27563

merged 2 commits into from
Apr 10, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 3, 2020 •
edited by engcom-Echo
Loading

Description (*)

This PR set correct url for CmsPageEditPage

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/176

@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Cms Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 3, 2020
lbajsarowicz
lbajsarowicz suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should proceed with moving towards {Area} + {Page} + Page suffix.
If you have some spare time you can rename the Page and it's references to:
AdminCmsPageEditPage.

The most important for now is just to get rid of generic parameter names.

app/code/Magento/Cms/Test/Mftf/Page/CmsPageEditPage.xml Outdated
@@ -7,7 +7,7 @@
-->
<pages xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/PageObject.xsd">
<page name="CmsPageEditPage" area="admin" url="admin/cms_page/edit/page_id/{{var}}" parameterized="true" module="Magento_Cms">
<page name="CmsPageEditPage" area="admin" url="cms/page/edit/page_id/{{var}}" parameterized="true" module="Magento_Cms">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, by the way, change this generic {{var}} to something more meaningful?

Suggested change
<page name="CmsPageEditPage" area="admin" url="cms/page/edit/page_id/{{var}}" parameterized="true" module="Magento_Cms">
<page name="CmsPageEditPage" area="admin" url="cms/page/edit/page_id/{{pageId}}" parameterized="true" module="Magento_Cms">

@ghost ghost assigned lbajsarowicz Apr 3, 2020
@lbajsarowicz
Copy link
Contributor

I think that previous URL was correct:
image

In my example you have:
/admin/ -> backend path
/admin/cms/... URL you try to change

@Usik2203
Copy link
Contributor Author

Usik2203 commented Apr 3, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Usik2203. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Usik2203, here is your Magento instance.
Admin access: https://i-27563-2-4-develop.instances.magento-community.engineering/admin_4985
Login: 52b7282e Password: 204ba286b5a3
Instance will be terminated in up to 3 hours.

@lbajsarowicz
Copy link
Contributor

@magento give me 2.3.4 instance

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your request. I'm working on Magento 2.3.4 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, here is your Magento instance.
Admin access: https://i-27563-2-3-4.instances.magento-community.engineering/admin_d4a6
Login: ec821e26 Password: 51926d76550a
Instance will be terminated in up to 3 hours.

@lbajsarowicz
Copy link
Contributor

OK. I was wrong. For some reason my local env prefixed that with /admin/.
So only replace the generic parameter name and we're good.

lbajsarowicz
lbajsarowicz approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Well done.
We need to wait for CI, to check if some PageBuilder / EE / B2B are not failing.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7255 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Apr 3, 2020

@lbajsarowicz Thanks for review this PR and recommendations.

@engcom-Delta engcom-Delta self-assigned this Apr 6, 2020
@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@engcom-Echo engcom-Echo self-assigned this Apr 6, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 7, 2020
@slavvka slavvka added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 8, 2020
magento-engcom-team pushed a commit that referenced this pull request Apr 10, 2020
@slavvka
ENGCOM-7255: [MFTF] Set correct url for CmsPageEditPage #27563
4b9dbf7
@magento-engcom-team magento-engcom-team merged commit 0f953f2 into magento:2.4-develop Apr 10, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Cms Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Usik2203 @lbajsarowicz @magento-engcom-team @engcom-Echo @engcom-Delta @VladimirZaets @slavvka