-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#27500 - Replace deprecated constructs from OfflinePa… #27627
magento/magento2#27500 - Replace deprecated constructs from OfflinePa… #27627
Conversation
Hi @cristiano-pacheco. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes. You can leave as it is, but if you have extra 5 minutes, just review what I suggest.
app/code/Magento/OfflinePayments/Test/Unit/Block/Info/CheckmoTest.php
Outdated
Show resolved
Hide resolved
app/code/Magento/OfflinePayments/Test/Unit/Block/Info/CheckmoTest.php
Outdated
Show resolved
Hide resolved
app/code/Magento/OfflinePayments/Test/Unit/Model/CheckmoConfigProviderTest.php
Show resolved
Hide resolved
Hi @lbajsarowicz, thank you for the review.
|
@cristiano-pacheco thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Failed functional tests not related to the changes in this PR |
Hi @cristiano-pacheco, thank you for your contribution! |
…yments PHPUnit.
Magento is slowly moving towards the latest dependencies in the PHP world. Part of this is to have (at least) supported version of PHPUnit ( https://phpunit.de/supported-versions.html )
Description (*)
Updated the tests of Offline_Payments to be compatible with PHPUnit 8.
Manual testing scenarios (*)