Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] Use Action Group to click on minicart #27671

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 9, 2020

Description (*)

This PR changes <click selector="{{StorefrontMinicartSection.showCart}}" stepKey="clickCart"/> to
<actionGroup ref="StorefrontClickOnMiniCartActionGroup" stepKey="clickCart"/> to click on minicart

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Apr 9, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7288 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Echo engcom-Echo self-assigned this Apr 10, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 10, 2020
@magento-engcom-team magento-engcom-team merged commit 8a90153 into magento:2.4-develop Apr 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants