Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Runtime.php #2769

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Update Runtime.php #2769

merged 1 commit into from
Mar 2, 2016

Conversation

dverkade
Copy link
Member

Constructor shoud use an interface, so that any class implementing the interface can be passed into this class.

Constructor shoud use an interface, so that any class implementing the interface can be passed into this class.
@davidalger
Copy link
Member

Thank you for the PR! We are currently waiting for the travis builds to work again, which should happen in a few days. Once that is running and the tests are green we can continue to process your contribution. In the mean time, can you please sign the contributor license agreement?

@dverkade
Copy link
Member Author

dverkade commented Dec 21, 2015

Hi David,

Thank you for your e-mail. Could you please send me a copy of the
agreement?

@davidalger
Copy link
Member

@dverkade At the bottom of GitHub pull request pages you'll see status checks for Travis, and also one for the "license/cla" and that's the one you need to act on to change green. You do that by clicking "Details" or following this URL (what it points to): https://cla.dev.magento.com/magento/magento2?pullRequest=2769

Thanks!

@mazhalai
Copy link
Contributor

@dverkade Please merge latest from develop and rerun builds.

@dsikkema-magento
Copy link
Contributor

Internal ticket: MAGETWO-49871

@dverkade could you please take a look at the failing travis builds?

@dsikkema-magento dsikkema-magento added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 26, 2016
@dverkade
Copy link
Member Author

dverkade commented Feb 26, 2016 via email

@okorshenko
Copy link
Contributor

@dverkade Thank you for contribution. We will try re-run tests for your PR using our internal infrastructure.

@magento-team magento-team merged commit 7dd1687 into magento:develop Mar 2, 2016
magento-team pushed a commit that referenced this pull request Mar 2, 2016
@dverkade dverkade deleted the patch-1 branch June 22, 2018 14:54
magento-engcom-team pushed a commit that referenced this pull request Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants